Verified Commit cb00093e authored by Bernd Paysan's avatar Bernd Paysan
Browse files

Make sure your secrets aren't tainted

parent fd83079a

ed25519-donna-impl-base.h

+4 −4
Original line number Diff line number Diff line
@@ -291,8 +291,8 @@ STATIC void ge25519_double_scalarmult_vartime(ge25519 *r, const ge25519 *p1, con 


		ge25519_p1p1_to_partial(r, &t);

	}

	expilcit_bzero(slide1, sizeof(slide1));

	expilcit_bzero(slide2, sizeof(slide2));

	explicit_bzero(slide1, sizeof(slide1));

	explicit_bzero(slide2, sizeof(slide2));

}



/* computes [s1]p1 */
@@ -327,7 +327,7 @@ STATIC void ge25519_scalarmult_vartime(ge25519 *r, const ge25519 *p1, const bign 


		ge25519_p1p1_to_partial(r, &t);

	}

	expilcit_bzero(slide1, sizeof(slide1));

	explicit_bzero(slide1, sizeof(slide1));

}



/*
@@ -443,7 +443,7 @@ STATIC void ge25519_scalarmult(ge25519 *r, const ge25519 *p1, const bignum256mod 
		ge25519_pnielsadd_p1p1(&t, r, &pre, (unsigned char)slide1[i] >> 7);

		ge25519_p1p1_to_partial(r, &t);

	}

	expilcit_bzero(slide1, sizeof(slide1));

	explicit_bzero(slide1, sizeof(slide1));

}



#if !defined(HAVE_GE25519_SCALARMULT_BASE_CHOOSE_NIELS)

ed25519-donna-impl-sse2.h

+4 −4
Original line number Diff line number Diff line
@@ -328,8 +328,8 @@ ge25519_double_scalarmult_vartime(ge25519 *r, const ge25519 *p1, const bignum256 


		ge25519_p1p1_to_partial(r, &t);

	}

	expilcit_bzero(slide1, sizeof(slide1));

	expilcit_bzero(slide2, sizeof(slide2));

	explicit_bzero(slide1, sizeof(slide1));

	explicit_bzero(slide2, sizeof(slide2));

}



#ifndef MM16
@@ -370,7 +370,7 @@ ge25519_scalarmult_vartime(ge25519 *r, const ge25519 *p1, const bignum256modm s1 


		ge25519_p1p1_to_partial(r, &t);

	}

	expilcit_bzero(slide1, sizeof(slide1));

	explicit_bzero(slide1, sizeof(slide1));

}



DONNA_INLINE static void ge25519_cmove_stride4(long * r, long * p, long * pos, long * n, int stride) {
@@ -455,7 +455,7 @@ STATIC void ge25519_scalarmult(ge25519 *r, const ge25519 *p1, const bignum256mod 
		ge25519_pnielsadd_p1p1(&t, r, &pre, (unsigned char)slide1[i] >> 7);

		ge25519_p1p1_to_partial(r, &t);

	}

	expilcit_bzero(slide1, sizeof(slide1));

	explicit_bzero(slide1, sizeof(slide1));

}



#if !defined(HAVE_GE25519_SCALARMULT_BASE_CHOOSE_NIELS)